[pull] main from wpilibsuite:main #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modified handleDeleteProject to select the next project after deleteProject has finished. * Updated handleDeleteProject to select another project only if the current project is the one being deleted. Also keep the dialog up after deleting a project. Renamed project to currentProject and setProject to setCurrentProject in MenuProps. Renamed project to currentProject and setProject to setCurrentProject in ProjectManageModalProps. Added "Project Management" to i18n.
* Changed blocks (except the ones that are used in mutators) to not assume they are BlockSvg. * Added comment.
* Extracted code from mrc_class_method_def functions findLegalMethodName and isMethodNameUsed to make function makeLegalName in validator.ts. Updated mrc_class_method_def, mrc_component, mrc_event, and mrc_mechanism blocks to use makeLegalName. * Changed makeLegalName optionally return a valid python identifier. * Use makeLegalName to make names unique when mechanisms, components, and events are dragged into the holder. Use makeLegalName to validate parameter names. * Update comment about case insensitive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )