fix(gh-inputs): support maps of size 1#11
fix(gh-inputs): support maps of size 1#11alandefreitas merged 2 commits intoalandefreitas:developfrom
Conversation
|
Oh... I see. You must also run build.sh and include the changes in the commit. That's unfortunate but it's how GHA works. |
|
Hmm, I had to modify the build.sh script to include the projects in build.sh Diffdiff --git a/build.sh b/build.sh
old mode 100644
new mode 100755
index 36d3909..6fde3a9
--- a/build.sh
+++ b/build.sh
@@ -1,20 +1,8 @@
+#!/usr/bin/bash
# Description: Build all the javascript projects in the repository
-projects_with_package=()
-projects_with_action=()
-
-for dir in */; do
- # Ignore the docs directory
- if [ "$dir" == "docs/" ]; then
- continue
- fi
-
- if [ -f "$dir/package.json" ]; then
- projects_with_package+=("$dir")
- elif [ -f "$dir/action.yml" ]; then
- projects_with_action+=("$dir")
- fi
-done
+mapfile -t projects_with_package < <(find . -type f -name "package.json" ! -path "*/node_modules/*" ! -path "*/docs/*" -exec dirname {} \; | sed 's|^\./||')
+mapfile -t projects_with_action < <(find . -type f -name "action.yml" ! -path "*/node_modules/*" ! -path "*/docs/*" -exec dirname {} \; | sed 's|^\./||')
project_to_build=$1 |
|
GHA doesn't need the build directory for the projects in the common directory because they're not actions and other projects already include them in their package.json. So commits shouldn't include their build directories. They're already listed in .gitignore.
Yes. I'd have to study that. :) |
|
Could you confirm these failures are unrelated to your changes? I believe they are because these actions are living things, and new problems with new containers must be fixed occasionally. |
Oh yea, they don't need to be built, but they need to have their (dev-)dependencies installed, because they have a Changing
Tried a blank run in Nerixyz#1 (with just an empty commit). The fmt issue could probably be solved by updating it. |
|
Mmm... I never had theses problems but I guess that's more of a problem with the manifest files anyway. Thanks! :) |
I was wondering why
subrange-policy: "msvc: one-per-minor"didn't work for me1. It turns out,parseMapwill emit the first entry as{key: "msvc", value: "one-per-minor"}.Footnotes
It doesn't work in this repository either - see line 139 in
Generate Test Matrixin https://github.com/alandefreitas/cpp-actions/actions/runs/12718660506/job/35457506938. ↩