Open
Conversation
Owner
|
Oh... Nice. |
Owner
|
The PR looks excellent. It's not passing CI, but that's not the fault of this PR. CI is unmaintained. Let me know if you think this is good to go or if you want to look at CI first. It's up to you. Thanks. |
Author
|
Hi @alandefreitas, sorry I've been busy the last few days but I will try to PR a fix for CI as soon as I have some time to figure out why Windows builds currently segfault on my branch (https://github.com/goraj/pareto/actions/runs/9481171577/job/26123365116). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alandefreitas,
Thank you for making pareto available!
Current pareto repository won't build on OSX/arm due to CATCH_TRAP issue in pareto's Catch2 version lacking support for instruction set.
PR will updates CPM, Catch2, pybind11 to use recent release versions. More recent CMake version would also make cotire obsolete.
Builds and tests fine on recent OSX arm.
Also tested python bindings: