Get-VIEventPlus taking a long time on vCenter 8.0u3 and later

[adam-ahern]

Issue was reported in #766

I was able to reproduce the issue in an 8.0u3 lab using PowerCLI 13.3

Running the vCheck script with Trace set to 1 showed the Get-VIEventPlus going into a long loop to add events to a list checking through each event 1 by 1.

vCheck-vSphere/Plugins/00 Initialize/00 Connection Plugin for vCenter.ps1

Lines 465 to 472 in e248cf2

	while($eventsBuffer){
	ForEach ($Item in $eventsBuffer) {
	if (-not $UseUTC) {
	$Item.CreatedTime = $Item.CreatedTime.ToLocalTime()
	}
	$events.add($Item)
	}
	}

I added code to retrieve more events at a time, and process them in larger batches

DEBUG:   24+     >>>> $DRSMigrations = Get-VIEventPlus -Start $Date.AddDays(-$DRSMigrateAge) -EventType 'DrsVmMigratedEvent' | Select-Object CreatedTime, FullFormattedMessage
...
DEBUG:  464+           >>>> $eventsBuffer = $eventCollector.ReadNextEvents($eventnumber)
DEBUG:  465+          while( >>>> $eventsBuffer){
DEBUG:  466+             ForEach ($Item in  >>>> $eventsBuffer) {
DEBUG:  466+             ForEach ( >>>> $Item in $eventsBuffer) {
DEBUG:  467+                 if ( >>>> -not $UseUTC) {
DEBUG:  468+                      >>>> $Item.CreatedTime = $Item.CreatedTime.ToLocalTime()
DEBUG:  470+                  >>>> $events.add($Item)
DEBUG:  466+             ForEach ( >>>> $Item in $eventsBuffer) {
DEBUG:  467+                 if ( >>>> -not $UseUTC) {
DEBUG:  468+                      >>>> $Item.CreatedTime = $Item.CreatedTime.ToLocalTime()
DEBUG:  470+                  >>>> $events.add($Item)

Summary by Sourcery

Bug Fixes:

• Fixes an issue where Get-VIEventPlus takes a long time to run on vCenter 8.0u3 and later due to inefficient event retrieval.

[sourcery-ai]

Reviewer's Guide by Sourcery

The Get-VIEventPlus function was taking a long time to execute on vCenter 8.0u3 and later due to retrieving events one by one. To address this, the code was modified to retrieve events in larger batches, significantly improving performance. The number of events retrieved per call was increased from 100 to 1000, and a loop was added to process these batches.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Increased the number of events retrieved per call to improve performance.	Increased the number of events retrieved per call from 100 to 1000. Added a loop to continue reading events in batches.	Plugins/00 Initialize/00 Connection Plugin for vCenter.ps1

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @adam-ahern - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a comment explaining why the event number was increased to 1000.
• It might be worth extracting the event processing logic into a separate function for better readability.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rebelinux]

Tested in my homelab with good results!