Conversation
- Add Quick Start section with step-by-step instructions - Document all transport modes (stdio, streamable-http, sse) - Add Docker usage examples for all transports - Update VS Code and Claude Desktop configuration examples - Update Python version badge to 3.12+
There was a problem hiding this comment.
Pull request overview
This PR updates the README.md documentation to improve clarity and provide more comprehensive setup and usage instructions, while also updating the minimum Python version requirement from 3.11+ to 3.12+.
Key Changes:
- Updated Python version requirement from 3.11+ to 3.12+
- Added detailed Quick Start guide with step-by-step instructions
- Reorganized installation and usage sections with more examples for different transport modes and deployment methods
- Expanded Docker usage documentation including Docker Compose profiles and VS Code integration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "--with", | ||
| "mcp[cli]", | ||
| "--with", | ||
| "trino", | ||
| "--with", | ||
| "loguru", | ||
| "mcp", | ||
| "run", | ||
| "/path/to/mcp-trino-python/src/server.py" |
There was a problem hiding this comment.
The VS Code configuration uses an unconventional command structure that mixes uv run --with dependencies with what appears to be an MCP CLI wrapper command (mcp run). This differs from the simpler usage shown in line 69 (uv run src/server.py).
Consider either:
- Using the simpler
uv runapproach:["run", "src/server.py"](assuming dependencies are installed viauv sync) - Or clarifying if this is intended to use the MCP CLI wrapper and adjusting accordingly
The current structure uv run --with mcp[cli] --with trino --with loguru mcp run /path/to/... appears to be trying to do both, which may not work as intended.
| "--with", | |
| "mcp[cli]", | |
| "--with", | |
| "trino", | |
| "--with", | |
| "loguru", | |
| "mcp", | |
| "run", | |
| "/path/to/mcp-trino-python/src/server.py" | |
| "src/server.py" |
| ```bash | ||
| TRINO_HOST=localhost | ||
| TRINO_PORT=8080 | ||
| TRINO_USER=trino | ||
| TRINO_CATALOG=tpch | ||
| TRINO_SCHEMA=tiny | ||
| ``` |
There was a problem hiding this comment.
[nitpick] The environment file example uses bash syntax highlighting (line 39) but contains environment variable assignments, not bash commands. This should use a different code fence language identifier or none at all:
TRINO_HOST=localhost
TRINO_PORT=8080
...
Or use env or properties for syntax highlighting instead of bash.
Pull Request Title
Description
A clear and concise description of what this pull request does.
Related Issues
Link any related issues or pull requests.
Description
A clear and concise description of what this pull request does.
Related Issues
Link any related issues or pull requests.
Checklist