-
Notifications
You must be signed in to change notification settings - Fork 0
fix Reverse sync logic and re-apply deletion of source sha #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis change removes the Changes
Sequence Diagram(s)No sequence diagram generated as changes are limited to metadata removal, formatting, and workflow variable declaration updates. Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (53)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes obsolete sourceSHA metadata from documentation files and fixes quoting in the reverse-sync GitHub Actions workflow to ensure paths and the pull request title are handled correctly.
- Removed
sourceSHAlines from frontmatter in various.mdx/.mdfiles - Updated
SYNCED_PATHSto be quoted in the workflow - Changed
pr_titleassignment to use single quotes (which needs correction)
Reviewed Changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/en/**/*.{mdx,md} | Removed sourceSHA frontmatter property across many docs |
| .github/workflows/reverse-sync.yml | Quoted SYNCED_PATHS and modified pr_title assignment |
Comments suppressed due to low confidence (1)
.github/workflows/reverse-sync.yml:28
- Using single quotes prevents the GitHub Actions expression from being expanded; use double quotes (
pr_title="${{ github.event.pull_request.title }}") so the title is correctly substituted.
pr_title='${{ github.event.pull_request.title }}'
Co-authored-by: Copilot <[email protected]>
Summary by CodeRabbit
Documentation
sourceSHAmetadata field from multiple documentation files for a cleaner and more consistent front matter.Style