Skip to content

fix(deps): @total-typescript/ts-reset should be listed as dependency#78

Merged
JounQin merged 2 commits intomainfrom
fix/deps
Jun 9, 2025
Merged

fix(deps): @total-typescript/ts-reset should be listed as dependency#78
JounQin merged 2 commits intomainfrom
fix/deps

Conversation

@JounQin
Copy link
Member

@JounQin JounQin commented Jun 9, 2025

Summary by CodeRabbit

  • Chores

    • Updated several dependencies to their latest versions.
    • Adjusted dependency management to ensure correct package installation.
  • Refactor

    • Improved domain management logic for better performance and maintainability.

@JounQin JounQin self-assigned this Jun 9, 2025
Copilot AI review requested due to automatic review settings June 9, 2025 09:26
@JounQin JounQin added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 9, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 821db0c

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Jun 9, 2025

Walkthrough

This update modifies dependency management by moving @total-typescript/ts-reset from devDependencies to dependencies and updates versions for several packages in package.json. It also refactors the handling of allowed legacy domains in the VersionsNav component to use a Set instead of an array. A new changeset documents these adjustments.

Changes

File(s) Change Summary
.changeset/big-berries-joke.md Added a changeset file documenting a dependency fix for @alauda/doom regarding ts-reset.
package.json Updated versions of several dependencies and moved @total-typescript/ts-reset to dependencies.
src/global/VersionsNav/index.tsx Refactored allowed legacy domains from an array to a Set, updating related logic accordingly.

Poem

A hop, a skip, a version bump,
Dependencies shuffled with a gentle thump.
Arrays to Sets, domains now neat,
The code hops forward on nimble feet.
With every patch and tidy change,
The rabbit’s world grows less strange! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9e825d and 821db0c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • .changeset/big-berries-joke.md (1 hunks)
  • package.json (3 hunks)
  • src/global/VersionsNav/index.tsx (2 hunks)
🔇 Additional comments (4)
package.json (2)

61-61: Dependency version updates look good.

The version bumps for @eslint-react/eslint-plugin, es-toolkit, and prettier-plugin-pkg are appropriate maintenance updates.

Also applies to: 79-79, 131-131


73-73:

Details

✅ Verification successful

Verify the necessity of moving @total-typescript/ts-reset to dependencies.

This change moves @total-typescript/ts-reset from devDependencies to dependencies, which means it will be installed when users install your package. Ensure this is necessary - typically this package is only needed during development for TypeScript type improvements.


🏁 Script executed:

#!/bin/bash
# Check if @total-typescript/ts-reset is imported or referenced in runtime code
echo "Searching for imports/references to @total-typescript/ts-reset in source files..."
rg -g '!node_modules' -g '!lib' -g '!*.json' '@total-typescript/ts-reset' . || echo "No references found"

echo -e "\nChecking if package exports types that depend on ts-reset..."
fd -e '.d.ts' -t f | head -10 | xargs cat 2>/dev/null | head -20 || echo "No .d.ts files found in output"

Length of output: 1221


Move of @total-typescript/ts-reset to dependencies is correct

The global type declarations (global.d.ts) include

/// <reference types="@total-typescript/ts-reset" />

which makes ts-reset a required dependency for consumers’ type checking. Keeping it in devDependencies would break downstream type resolution.

No changes needed here.

.changeset/big-berries-joke.md (1)

1-6: Changeset documentation is accurate and well-formatted.

The changeset correctly documents the dependency change with appropriate patch-level versioning and clear description.

src/global/VersionsNav/index.tsx (1)

40-44: Set refactoring is correctly implemented.

The conversion from array to Set is properly done:

  • Constructor correctly initializes with array values
  • add() method properly replaces push()
  • has() method properly replaces includes()

This provides O(1) membership checking and better semantics for domain validation.

Also applies to: 141-141

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Signed-off-by: JounQin <admin@1stg.me>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes dependency management by ensuring that @total-typescript/ts-reset is listed correctly and bumps several dependency versions, while improving code maintainability in the VersionsNav component.

  • Updated dependency versions in package.json and removed a duplicate dependency entry.
  • Refactored legacy domain storage from an array to a Set, enabling more efficient membership checks in VersionsNav.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/global/VersionsNav/index.tsx Replaced an array with a Set for legacy domains and updated usage.
package.json Updated dependency versions and fixed duplicate dependency listing.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@alauda/doom@78

commit: 821db0c

@JounQin JounQin merged commit 698b3bb into main Jun 9, 2025
19 of 20 checks passed
@JounQin JounQin deleted the fix/deps branch June 9, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants