feat: remove medium form width and modify tag styles by yangxiaolang · Pull Request #586 · alauda/ui

yangxiaolang · 2025-07-07T07:52:51Z

Summary by CodeRabbit

Style
- Updated tag appearance by removing rounded corners and borders from multi-select tags.
- Adjusted mini tag height and updated info tag background and border colors for improved visual consistency.
- Increased the medium form item width for better layout adaptability.
Documentation
- Updated documentation to reflect the new default for tag roundness.
New Features
- Marked the medium form item width as deprecated in favor of large.
Refactor
- Changed the default value for tag roundness to false across components and stories for consistency.

changeset-bot · 2025-07-07T07:52:54Z

🦋 Changeset detected

Latest commit: d2b9cfa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@alauda/ui	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-07-07T07:52:57Z

Walkthrough

The updates adjust default styling and documentation for tag and form components. Tag components now have non-rounded corners by default, with related documentation and stories updated accordingly. Multi-select tag appearance is also changed to non-rounded and borderless. The medium form item width is deprecated, and its CSS variable is updated to a new width.

Changes

File(s)	Change Summary
src/tag/tag.component.ts, stories/tag/basic.component.ts	Changed default value of `round` property from `true` to `false` in Tag components.
stories/tag/basic.stories.ts, stories/tag/tag.mdx	Updated default `round` argument/property in Tag stories and docs from `true` to `false`.
src/select/multi-select/multi-select.component.html	Set `round` and `border` bindings for multi-select tags to `false`.
src/tag/tag.component.scss	Adjusted `.aui-tag--mini` height, and updated `.aui-tag--info` background and border colors.
src/form/form.types.ts	Marked `Medium` in `FormItemWidth` as deprecated with JSDoc and inline comment.
src/theme/_theme-preset.scss	Changed `--aui-form-item-width-m` from `436px` to `732px`.
.changeset/calm-shrimps-tie.md	Added changeset documenting patch update for tag style and form width changes.

Poem

A tag once round, now straight and neat,
Corners squared, a subtle feat.
The medium width, a note to heed—
Deprecated now, so large takes lead.
Colors shift, and docs align,
In every change, the styles refine!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e61afe0 and d2b9cfa.

📒 Files selected for processing (1)

.changeset/calm-shrimps-tie.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.changeset/calm-shrimps-tie.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Redirect rules - aui
GitHub Check: Header rules - aui
GitHub Check: Unit Test
GitHub Check: Release Beta
GitHub Check: Pages changed - aui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

src/form/form-item/form-item.component.scss (1)
88-96: Avoid hard-coding the key list – iterate the map itself

Manually listing the keys (large small) duplicates source-of-truth in the loop and will drift if new sizes are ever introduced.
-@each $key in large small {
-  $map: map-get($form-item-width, $key);
+@each $key, $map in $form-item-width {
   &--#{$key} {
     .aui-form-item__control {
       flex: 1;
       max-width: map-get($map, width);
     }
   }
 }
src/select/multi-select/multi-select.component.html (1)

44-45: Explicit false bindings may be unnecessary noise

If the <aui-tag> inputs default to false, the explicit [round]="false" / [border]="false" can be dropped for a cleaner template.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 45cac94 and 77ec33d.

📒 Files selected for processing (5)

src/form/form-item/form-item.component.scss (1 hunks)
src/form/form.types.ts (0 hunks)
src/select/multi-select/multi-select.component.html (1 hunks)
src/tag/tag.component.scss (1 hunks)
src/theme/_theme-preset.scss (0 hunks)

💤 Files with no reviewable changes (2)

src/theme/_theme-preset.scss
src/form/form.types.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

GitHub Check: Redirect rules - aui
GitHub Check: Header rules - aui
GitHub Check: Pages changed - aui
GitHub Check: Release Beta
GitHub Check: Unit Test

🔇 Additional comments (1)

src/form/form-item/form-item.component.scss (1)

4-11: Dropped medium references verified
I’ve searched the form-item component (SCSS/HTML/TS) and the wider codebase for any remaining medium size usages—CSS vars, template bindings, enums, or BEM modifiers—and found none. The medium entry can safely stay removed without dangling references.

src/tag/tag.component.scss

stories/tag/tag.mdx

src/form/form.types.ts

src/tag/tag.component.ts

src/form/form-item/form-item.component.scss

src/form/form.types.ts

JounQin · 2025-07-07T09:59:14Z

PR 标题写规范点儿吧

style: update tag info bg style: tag not default round chore: modify tag story

chore: compliant medium with large size

feat: review change feat: review change

.changeset/calm-shrimps-tie.md

Co-authored-by: JounQin <admin@1stg.me>

feat: remove medium form item

ff909d2

coderabbitai bot reviewed Jul 7, 2025

View reviewed changes

src/tag/tag.component.scss Show resolved Hide resolved

JounQin reviewed Jul 7, 2025

View reviewed changes

stories/tag/tag.mdx Outdated Show resolved Hide resolved

fengtianze reviewed Jul 7, 2025

View reviewed changes

src/form/form.types.ts Show resolved Hide resolved

src/tag/tag.component.ts Show resolved Hide resolved

JounQin reviewed Jul 7, 2025

View reviewed changes

src/form/form-item/form-item.component.scss Show resolved Hide resolved

JounQin reviewed Jul 7, 2025

View reviewed changes

src/form/form.types.ts Outdated Show resolved Hide resolved

JounQin reviewed Jul 7, 2025

View reviewed changes

src/form/form.types.ts Outdated Show resolved Hide resolved

yangxiaolang added 3 commits July 7, 2025 17:59

style: change tag

5219ed1

style: update tag info bg style: tag not default round chore: modify tag story

chore: compliant medium with large size

b309366

chore: compliant medium with large size

feat: review change

fde27e2

feat: review change feat: review change

yangxiaolang force-pushed the feat/modify-form-item-and-tag-size branch from 1906183 to fde27e2 Compare July 7, 2025 10:00

yangxiaolang changed the title ~~Feat/modify form item and tag size~~ feat: remove medium form width and modify tag styles Jul 7, 2025

JounQin previously approved these changes Jul 7, 2025

View reviewed changes

yangxiaolang enabled auto-merge (squash) July 8, 2025 01:29

yangxiaolang disabled auto-merge July 8, 2025 01:49

Create calm-shrimps-tie.md

e61afe0

yangxiaolang dismissed JounQin’s stale review via e61afe0 July 8, 2025 01:50

JounQin requested changes Jul 8, 2025

View reviewed changes

.changeset/calm-shrimps-tie.md Outdated Show resolved Hide resolved

Update .changeset/calm-shrimps-tie.md

d2b9cfa

Co-authored-by: JounQin <admin@1stg.me>

JounQin approved these changes Jul 8, 2025

View reviewed changes

yangxiaolang merged commit f255c12 into master Jul 8, 2025
7 checks passed

yangxiaolang deleted the feat/modify-form-item-and-tag-size branch July 8, 2025 05:43

alaudabot mentioned this pull request Jul 8, 2025

chore: release @alauda/ui #587

Merged

coderabbitai bot mentioned this pull request Jul 11, 2025

chore: revert tag style modify #589

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove medium form width and modify tag styles#586

feat: remove medium form width and modify tag styles#586
yangxiaolang merged 6 commits intomasterfrom
feat/modify-form-item-and-tag-size

yangxiaolang commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JounQin commented Jul 7, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yangxiaolang commented Jul 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JounQin commented Jul 7, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yangxiaolang commented Jul 7, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jul 7, 2025 •

edited

Loading

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)