-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): bump rules_java, stardoc and bazel_lib #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis change updates the versions and SHA256 checksums of several external dependencies in the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: https://app.greptile.com/review/github.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @albertocavalcante, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request to help everyone get up to speed quickly. This PR, authored by @albertocavalcante, is focused on performing routine dependency updates within the WORKSPACE.bazel file. Specifically, it bumps the versions of rules_java, stardoc, and aspect_bazel_lib to their latest versions and updates the corresponding SHA256 hashes and URLs.
Highlights
- Dependency Update: rules_java: The
rules_javadependency is updated from version7.3.1to7.4.0. This involves updating thesha256hash and the download URL in thehttp_archivedefinition. - Dependency Update: stardoc: The
io_bazel_stardocdependency, used for documentation generation, is updated from version0.5.0to0.5.6. This includes updating thesha256hash and the download URLs. - Dependency Update: aspect_bazel_lib: The
aspect_bazel_libdependency is updated from version2.14.0to2.17.1. This requires updating thesha256hash, the download URL, and thestrip_prefixvalue to match the new version.
Changelog
- WORKSPACE.bazel
- Updated
rules_javafrom 7.3.1 to 7.4.0 (lines 7-9) - Updated
io_bazel_stardocfrom 0.5.0 to 0.5.6 (lines 25-28) - Updated
aspect_bazel_libfrom 2.14.0 to 2.17.1, including updatingstrip_prefix(lines 38-40)
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several Bazel dependencies: rules_java, stardoc, and bazel_lib. Dependency updates are important for keeping the build system modern and secure, but they also require careful verification.
My main concerns revolve around ensuring the correctness of the new SHAs, verifying the new strip_prefix for aspect_bazel_lib, and addressing a potentially critical breaking change introduced by rules_java 7.4.0 regarding toolchain_type. Thorough testing is also essential after these updates.
Summary of Findings
- Critical:
rules_javaBreaking Change: The update torules_java7.4.0 requires a change in how Java toolchains are typed (@rules_java//java:toolchain_typeinstead of@bazel_tools//tools/jdk:toolchain_type). This will likely break the current build asBUILD.bazeluses the old type. This needs to be addressed. - Critical: SHA256 Verification: All updated SHA256 checksums for
rules_java,stardoc, andaspect_bazel_libmust be verified against the downloaded artifacts to ensure integrity and prevent supply chain attacks. This was highlighted in review comments. - Critical:
aspect_bazel_libstrip_prefixVerification: Thestrip_prefixforaspect_bazel_libneeds to be confirmed to match the archive structure of the new version. This was highlighted in a review comment. - High: Testing: It's crucial to thoroughly test the project (build and all tests) with these new dependency versions to catch any regressions or compatibility issues beyond the identified
rules_javabreaking change. - Medium: Changelog Review: Reviewing the changelogs for
rules_java(7.3.1 to 7.4.0),stardoc(0.5.0 to 0.5.6), andaspect_bazel_lib(2.14.0 to 2.17.1) is recommended to be aware of any other notable changes, features, or deprecations. - Medium: Security Audit: It's advisable to check if these new dependency versions have any known security vulnerabilities.
- Low: PR Description Enhancement (Process Improvement): For future dependency bump PRs, consider including links to release notes, confirmation of SHA verification, and a summary of testing performed in the PR description. This greatly helps reviewers. (Not commented on directly due to review settings).
Merge Readiness
This pull request updates critical build dependencies. Due to the identified critical issues, particularly the breaking change in rules_java and the need for SHA256/strip_prefix verification, I recommend that these changes not be merged until these points are fully addressed and verified.
Specifically:
- The
rules_javatoolchain type incompatibility must be resolved (likely requiring changes inBUILD.bazel) and tested. - All SHA256 checksums and the
strip_prefixforaspect_bazel_libmust be confirmed as correct. - The project should build successfully and all tests should pass with these updated dependencies.
As an AI, I am not authorized to approve pull requests. Please ensure these concerns are addressed and further reviewed before merging.
| sha256 = "976ef08b49c929741f201790e59e3807c72ad81f428c8bc953cdbeff5fed15eb", | ||
| urls = [ | ||
| "https://github.com/bazelbuild/rules_java/releases/download/7.3.1/rules_java-7.3.1.tar.gz", | ||
| "https://github.com/bazelbuild/rules_java/releases/download/7.4.0/rules_java-7.4.0.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating rules_java to 7.4.0 is a good step. However, there are a couple of critical points to address:
-
SHA256 Verification: Has the new SHA256 (
976ef08b49c929741f201790e59e3807c72ad81f428c8bc953cdbeff5fed15eb) forrules_java7.4.0 been verified against the artifact downloaded from the updated URL? This is crucial for security and integrity. -
Breaking Change:
rules_java7.4.0 introduces a significant change:Java toolchains are now configured using toolchain type
@rules_java//java:toolchain_typeinstead of@bazel_tools//tools/jdk:toolchain_type.
(Source: rules_java 7.4.0 Release Notes)Our project's
BUILD.bazelfile (line 21) currently definesdefault_remotejdk_11_toolchainusing@bazel_tools//tools/jdk:toolchain_type. This update torules_javawill likely break the build unlessBUILD.bazelis also updated to use@rules_java//java:toolchain_type.
Could you please confirm that the SHA256 is correct and outline how the breaking change regarding toolchain_type will be addressed? Has this been tested with the necessary changes in BUILD.bazel?
| sha256 = "dfbc364aaec143df5e6c52faf1f1166775a5b4408243f445f44b661cfdc3134f", | ||
| urls = [ | ||
| "https://mirror.bazel.build/github.com/bazelbuild/stardoc/releases/download/0.5.0/stardoc-0.5.0.tar.gz", | ||
| "https://github.com/bazelbuild/stardoc/releases/download/0.5.0/stardoc-0.5.0.tar.gz", | ||
| "https://mirror.bazel.build/github.com/bazelbuild/stardoc/releases/download/0.5.6/stardoc-0.5.6.tar.gz", | ||
| "https://github.com/bazelbuild/stardoc/releases/download/0.5.6/stardoc-0.5.6.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| sha256 = "e5131e44db23459bd1ed04635f2ae5436bc83f5e38629e07b75c0bf206f09245", | ||
| strip_prefix = "bazel-lib-2.17.1", | ||
| url = "https://github.com/bazel-contrib/bazel-lib/releases/download/v2.17.1/bazel-lib-v2.17.1.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the aspect_bazel_lib update to version 2.17.1:
- SHA256 Verification: Has the new SHA256 (
e5131e44db23459bd1ed04635f2ae5436bc83f5e38629e07b75c0bf206f09245) been verified against the artifact from the new URL? - Strip Prefix: The
strip_prefixhas been updated tobazel-lib-2.17.1. Has it been confirmed that this matches the directory structure within the downloadedbazel-lib-v2.17.1.tar.gzarchive?
These checks are important for the correct integration of the dependency.
Summary by CodeRabbit