Implement display and other format conversions #26
Conversation
|
🤖 Hi @albertomercurio, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces a significant and valuable refactoring by centralizing sparse matrix format conversions into a dedicated conversions.jl file. The addition of comprehensive display functionalities for sparse matrices and the inclusion of extensive tests for the new conversion logic, including edge cases, are excellent improvements.
🔍 General Feedback
- The code is well-structured, and the separation of concerns with the new conversions file improves maintainability.
- The defensive copying of input arrays in the constructors is a good practice that enhances robustness.
- One minor point of feedback is the removal of docstrings for the
+operator insrc/core.jl. Restoring this documentation would be beneficial for users of the library.
Overall, this is a high-quality contribution that significantly improves the library's functionality and structure.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 84.34% 82.64% -1.70%
==========================================
Files 13 14 +1
Lines 728 801 +73
==========================================
+ Hits 614 662 +48
- Misses 114 139 +25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Introduced JLArrays as a weak dependency in Project.toml. - Enabled benchmark conversions for JLArray in runbenchmarks.jl. - Added helper functions for sorting and cumulative sum using AcceleratedKernels in helpers.jl. - Updated conversion tests to include JLArray support in shared test conversions. - Created DeviceSparseArraysJLArraysExt.jl for JLArray specific operations.
Fixes #6