Conversation
yadvendar
changed the title
|
@yadvendar thank you for this contribution. It looks like there's something funky happening with the commits included in this PR. Commits such as "Merge branch release-0.4.2" and "Bump version to 0.4.2" should not be here. Did you create a fork off of the master branch instead of develop? Relatedly, I'm in the process of simplifying the process I use for third-party contributions across all my projects. The current process described in CONTRIBUTING.md has some advantages, but it's become obvious that it causes a lot of confusion. I'm going to change to something that I expect people will be more familiar with. For now, would you mind creating a fork of the develop branch and opening a new PR? |
1. Support to setup prefix as part of config
2. Modify lua scripts to remove dependency from hard coded key prefix -
"jobs:".
3. Process environmental prefix and hard coded prefix("jobs:") and then
pass them to lua scripts. This helps in generating scripts.go only once
and use it from other packages as required supporting multiple
configurable environmental prefixes.
4. Ran go fmt.
(cherry picked from commit 34e9b67)
(cherry picked from commit 2ceff7e)
yadvendar
force-pushed
the
support-env-prefix-to-redis-keys
branch
from
2ceff7e to
0eba5d1
Compare
|
@albrow Oh! I missed that in CONTRIBUTING.md (create fork of the develop and not master) and went on to create fork of the master branch. The current process looks good to me, it was more of my bad on missing that out. Just curious to know, what is the other simplified process you are talking about? Now, instead of creating a new PR I have updated this PR only with the desired change i.e. create the fork of the develop. Hope this helps. |
2 participants
Enhancement as per the Issue #42