Conversation
daa243b to
474277d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 29 29
Lines 2444 2446 +2
Branches 464 464
=======================================
+ Hits 2420 2422 +2
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses pandas warnings by replacing deprecated .apply(lambda x: round(x, prec)) patterns with the modern .round(prec) method, and adding .copy() to chained indexing operations to avoid SettingWithCopyWarning.
Key Changes:
- Replaced
.apply(lambda x: round(x, prec))with.round(prec)for better performance and to eliminate deprecation warnings - Added
.copy()after.ilocindexing to prevent pandas SettingWithCopyWarning - Refactored multi-column rounding operations to use intermediate variables for clarity
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/alchemlyb/parsing/lammps.py | Updated pandas operations to use modern methods and avoid chained indexing warnings across multiple functions |
| CHANGES | Added changelog entry documenting the fix for pandas warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
orbeckst
left a comment
There was a problem hiding this comment.
lgtm, will just add you to CHANGES
No description provided.