Conversation
commit: |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| # Install dependencies for examples that need separate installation | ||
| if [ -d "examples/cloudflare-tanstack-start" ]; then | ||
| cd examples/cloudflare-tanstack-start | ||
| bun install --frozen-lockfile | ||
| cd ../.. | ||
| fi |
There was a problem hiding this comment.
not sure if this is necessary @sam-goodwin wdyt?
There was a problem hiding this comment.
tanstack start has a weird problem where it wasn't working in a monorepo. You could try adding it back to workspaces in package.json and see if that's still a problerm
There was a problem hiding this comment.
It seems to work without installing it individually, pushed the change 🙏
|
Closing this. Didn't have bandwidth to consider this as part of our workflow. Happy to re-visit. |
2 participants
This pull request introduces a CodeQL integration for the repository to enhance security and quality analysis. The main changes include the addition of a CodeQL configuration file and a GitHub Actions workflow to automate the analysis process.
CodeQL Integration:
.github/codeql/codeql-config.yml: Added a configuration file specifying paths to include/exclude in analysis, query packs, and custom query filters for CodeQL scans.Automation via GitHub Actions:
.github/workflows/codeql-analysis.yml: Added a workflow to run CodeQL analysis onpushandpull_requestevents for themainbranch, as well as on a weekly schedule. Includes steps for repository checkout, dependency installation, and CodeQL analysis execution.