feat: auto retry certain errors #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mkassabov
force-pushed
the
mkassabov/retry-errors
branch
from
baa60fb to
c9cfcfd
Compare
commit: |
sam-goodwin
reviewed
Nov 12, 2025
Comment on lines
+261
to
+274
| return program.pipe( | ||
| Effect.tapError((e) => | ||
| Effect.logDebug("AWS Request Failed, Retrying...", { | ||
| error: e, | ||
| }), | ||
| ), | ||
| Effect.retry({ | ||
| schedule: Schedule.intersect( | ||
| Schedule.exponential("100 millis"), | ||
| Schedule.recurs(5), | ||
| ), | ||
| while: (e) => retryableErrorTags.includes(e._tag), | ||
| }), | ||
| ); |
Collaborator
There was a problem hiding this comment.
Is there a way we can make this configurable or injectable as a layer with a sensible default.
sam-goodwin
reviewed
Nov 12, 2025
Comment on lines
+11
to
+18
| export const retryableErrorTags = [ | ||
| "InternalFailure", | ||
| "RequestExpired", | ||
| "ServiceException", | ||
| "ServiceUnavailable", | ||
| "ThrottlingException", | ||
| "TooManyRequestsException", | ||
| ]; |
Collaborator
There was a problem hiding this comment.
Is this all of the errors? Can we extract them. Maybe the smithy models has information we cam use, e.g. all 5xx errors should be retried. Maybe there's other metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.