feat: key export #2249
Merged
feat: key export #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
🌿 Documentation Preview
|
florrdv
requested review from
0xfourzerofour,
AlvaroLuken,
Dan-Nolan,
Richard-Dang,
SahilAujla,
adamegyed,
androbwebb,
andysim3d,
avarobinson,
blakecduncan,
dancoombs,
jakehobbs,
linnall,
niveda-krish,
noam-alchemy and
thebrianchen
as code owners
jakehobbs
previously approved these changes
Nov 13, 2025
trevoraron
reviewed
Nov 13, 2025
| opts.type === "ETHEREUM" | ||
| ? "ADDRESS_FORMAT_ETHEREUM" | ||
| : "ADDRESS_FORMAT_SOLANA"; | ||
| const keyFormat = opts.type === "ETHEREUM" ? "HEXADECIMAL" : "SOLANA"; |
Collaborator
There was a problem hiding this comment.
lol that the key format type is solana here and not b58
jakehobbs
previously approved these changes
Dec 19, 2025
|
|
||
| const wallets = await turnkeyClient.getWalletAccounts({ organizationId }); | ||
| const account = wallets.accounts.find( | ||
| (account) => account.addressFormat === targetAddressFormat, |
Contributor
There was a problem hiding this comment.
it should be impossible for one TK sub-org to have multiple eth wallets, correct?
Contributor
Author
There was a problem hiding this comment.
correct in our setup
jakehobbs
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR introduces functionality for exporting private keys in an encrypted format, enhancing security for both single and multi-owner accounts. It adds new interfaces and methods to facilitate this process, allowing users to export their private keys securely.
Detailed summary
exportPrivateKeyEncryptedmethod to export a private key encrypted with a public key.ExportPrivateKeyParamsandMultiOwnerExportPrivateKeyParamsinterfaces for export parameters.ExportPrivateKeyEncryptedResultinterface for the export result structure.experimental_multiOwnerExportPrivateKeyEncryptedmethod for multi-owner organizations, leveraging the new export functionality.