Skip to content

ci: format lerna config after publishing#2382

Merged
jakehobbs merged 1 commit intomainfrom
jake/format-v5-publish-action
Mar 6, 2026
Merged

ci: format lerna config after publishing#2382
jakehobbs merged 1 commit intomainfrom
jake/format-v5-publish-action

Conversation

@jakehobbs
Copy link
Collaborator

@jakehobbs jakehobbs commented Mar 5, 2026

Pull Request Checklist


PR-Codex overview

This PR updates the .github/workflows/publish-v5-beta.yml file to improve the linting process for version changes before committing them, ensuring that committed files adhere to lint checks.

Detailed summary

  • Added a new step named Format Version Changes that runs yarn lint:write if the input publish is true.
  • Removed the Commit Version Changes step's name, but kept its conditional check for publish.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
aa-sdk-ui-demo Ready Ready Preview, Comment Mar 5, 2026 2:30am

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a formatting step to the v5 beta publish workflow to ensure that files modified during version bumping (e.g., lerna.json, package.json files, and auto-generated version.ts files) pass lint checks before they are committed. The root yarn lint:write script runs eslint . --fix && prettier --loglevel warn --write --ignore-unknown ., which aligns with how lint:write is already used in the PR check workflow (on-pull-request.yml) to format generated files before a git diff check.

Changes:

  • Adds a new "Format Version Changes" step between "Inject Versions" and "Commit Version Changes" in the v5 beta publish workflow, running yarn lint:write to auto-format any files modified by the preceding version-bump and inject-version steps.

@jakehobbs jakehobbs merged commit 980001b into main Mar 6, 2026
16 checks passed
@jakehobbs jakehobbs deleted the jake/format-v5-publish-action branch March 6, 2026 18:34
@jakehobbs jakehobbs restored the jake/format-v5-publish-action branch March 6, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants