fix: test_eth_sendUserOperation #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
test_eth_sendUserOperationcase to pass.Run as manual building mode.
Need to run Rundler as manual building mode, since it ignores
debug_bundler_sendBundleNowrequest when running as auto mode.Adding a dummy valid user operation to the pool
test_eth_sendUserOperation_revertwas failing withError(code=-32603, message='no ops to send', data=None, id=7). BuildProposer checks the existence of User Operations in the pool before making a bundle before and after simulation.If I understand correctly, Rundler intentionally do so not to propose unncessary bundles with empty User Operations (If it's an unexpected behavior, modification on Rundler code required), thus spec test case need to be adjusted to proceed following test cases.
Result
