feat: remove EIP-191 user operation hash wrapping in SMA and validata… #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|------------------------------|------------------|-------------------|--------------------|---------------------|
| AccountFactory | 6,604 | 7,071 | 17,972 | 42,081 |
| Address | 16 | 44 | 24,560 | 49,108 |
| AllowlistModule | 10,148 | 10,174 | 14,428 | 38,978 |
| Base64 | 16 | 44 | 24,560 | 49,108 |
| Create2 | 16 | 44 | 24,560 | 49,108 |
| ECDSA | 16 | 44 | 24,560 | 49,108 |
| ERC165Checker | 16 | 44 | 24,560 | 49,108 |
| ERC1967Utils | 16 | 44 | 24,560 | 49,108 |
| ExecutionInstallDelegate | 5,835 | 5,880 | 18,741 | 43,272 |
| FCL_Elliptic_ZZ | 16 | 44 | 24,560 | 49,108 |
| FCL_ecdsa | 16 | 44 | 24,560 | 49,108 |
| Math | 16 | 44 | 24,560 | 49,108 |
| MessageHashUtils | 16 | 44 | 24,560 | 49,108 |
| ModularAccount | 22,935 | 23,323 | 1,641 | 25,829 |
| NativeTokenLimitModule | 4,917 | 4,943 | 19,659 | 44,209 |
| PaymasterGuardModule | 2,028 | 2,054 | 22,548 | 47,098 |
| SafeERC20 | 16 | 44 | 24,560 | 49,108 |
-| SemiModularAccount7702 | 23,380 | 23,761 | 1,196 | 25,391 |
-| SemiModularAccountBytecode | 23,856 | 24,244 | 720 | 24,908 |
+| SemiModularAccount7702 | 23,336 | 23,717 | 1,240 | 25,435 |
+| SemiModularAccountBytecode | 23,812 | 24,200 | 764 | 24,952 |
| SignatureChecker | 16 | 44 | 24,560 | 49,108 |
| SignedMath | 16 | 44 | 24,560 | 49,108 |
-| SingleSignerValidationModule | 3,892 | 3,918 | 20,684 | 45,234 |
+| SingleSignerValidationModule | 3,853 | 3,879 | 20,723 | 45,273 |
| StorageSlot | 16 | 44 | 24,560 | 49,108 |
| Strings | 16 | 44 | 24,560 | 49,108 |
| TimeRangeModule | 2,435 | 2,461 | 22,141 | 46,691 |
| WebAuthn | 16 | 44 | 24,560 | 49,108 |
| WebAuthnFactory | 4,318 | 4,741 | 20,258 | 44,411 |
-| WebAuthnValidationModule | 9,319 | 9,345 | 15,257 | 39,807 |
+| WebAuthnValidationModule | 9,277 | 9,303 | 15,299 | 39,849 |Code coverage:
|
dancoombs
force-pushed
the
danc/remove-191-wrap
branch
from
368b971 to
dccd8e7
Compare
dancoombs
force-pushed
the
danc/remove-191-wrap
branch
from
dccd8e7 to
b3e2e8a
Compare
dancoombs
force-pushed
the
danc/remove-191-wrap
branch
2 times, most recently
from
8e84472 to
59e92de
Compare
dancoombs
force-pushed
the
danc/remove-191-wrap
branch
from
59e92de to
acd6a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion modules
Motivation
Solution