-
Notifications
You must be signed in to change notification settings - Fork 63
feat: update to use entrypoint v0.9 #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Forgot to commit the bytecode files |
|
Contract sizes: | Contract | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|------------------------------|------------------|-------------------|--------------------|---------------------|
-| AccountFactory | 6,661 | 7,135 | 17,915 | 42,017 |
-| AllowlistModule | 10,336 | 10,363 | 14,240 | 38,789 |
-| ExecutionInstallDelegate | 5,947 | 5,993 | 18,629 | 43,159 |
-| ModularAccount | 23,273 | 23,672 | 1,303 | 25,480 |
-| NativeTokenLimitModule | 5,093 | 5,120 | 19,483 | 44,032 |
-| PaymasterGuardModule | 2,097 | 2,124 | 22,479 | 47,028 |
-| SemiModularAccount7702 | 23,741 | 24,133 | 835 | 25,019 |
-| SemiModularAccountBytecode | 24,223 | 24,622 | 353 | 24,530 |
-| SingleSignerValidationModule | 3,976 | 4,003 | 20,600 | 45,149 |
-| TimeRangeModule | 2,504 | 2,531 | 22,072 | 46,621 |
-| WebAuthnFactory | 4,367 | 4,801 | 20,209 | 44,351 |
-| WebAuthnValidationModule | 9,462 | 9,489 | 15,114 | 39,663 |
+| AccountFactory | 6,604 | 7,071 | 17,972 | 42,081 |
+| Address | 16 | 44 | 24,560 | 49,108 |
+| AllowlistModule | 10,148 | 10,174 | 14,428 | 38,978 |
+| Base64 | 16 | 44 | 24,560 | 49,108 |
+| Create2 | 16 | 44 | 24,560 | 49,108 |
+| ECDSA | 16 | 44 | 24,560 | 49,108 |
+| ERC165Checker | 16 | 44 | 24,560 | 49,108 |
+| ERC1967Utils | 16 | 44 | 24,560 | 49,108 |
+| ExecutionInstallDelegate | 5,835 | 5,880 | 18,741 | 43,272 |
+| FCL_Elliptic_ZZ | 16 | 44 | 24,560 | 49,108 |
+| FCL_ecdsa | 16 | 44 | 24,560 | 49,108 |
+| Math | 16 | 44 | 24,560 | 49,108 |
+| MessageHashUtils | 16 | 44 | 24,560 | 49,108 |
+| ModularAccount | 22,935 | 23,323 | 1,641 | 25,829 |
+| NativeTokenLimitModule | 4,917 | 4,943 | 19,659 | 44,209 |
+| PaymasterGuardModule | 2,028 | 2,054 | 22,548 | 47,098 |
+| SafeERC20 | 16 | 44 | 24,560 | 49,108 |
+| SemiModularAccount7702 | 23,380 | 23,761 | 1,196 | 25,391 |
+| SemiModularAccountBytecode | 23,856 | 24,244 | 720 | 24,908 |
+| SignatureChecker | 16 | 44 | 24,560 | 49,108 |
+| SignedMath | 16 | 44 | 24,560 | 49,108 |
+| SingleSignerValidationModule | 3,892 | 3,918 | 20,684 | 45,234 |
+| StorageSlot | 16 | 44 | 24,560 | 49,108 |
+| Strings | 16 | 44 | 24,560 | 49,108 |
+| TimeRangeModule | 2,435 | 2,461 | 22,141 | 46,691 |
+| WebAuthn | 16 | 44 | 24,560 | 49,108 |
+| WebAuthnFactory | 4,318 | 4,741 | 20,258 | 44,411 |
+| WebAuthnValidationModule | 9,319 | 9,345 | 15,257 | 39,807 |Code coverage:
|
8c22396 to
2cd128a
Compare
2cd128a to
00d4415
Compare
fix: commit ep v0.9.0 bytecode file
00d4415 to
151ee74
Compare
| target: address(erc20), value: 0, data: abi.encodeCall(IERC20.approve, (recipient, 9 ether + 100_000)) | ||
| }); | ||
|
|
||
| vm.startPrank(address(entryPoint)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - this isn't needed
| // update | ||
| assertEq(senderCreator.codehash, 0xa7d4dd260bca9c96da49f7c0682fdda7f0074694d935815a336d3e60ee3ec6ad); | ||
| // update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: leftover // update comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix in a follow up
Motivation
Solution