Skip to content

Conversation

@dancoombs
Copy link
Collaborator

Motivation

Solution

@dancoombs
Copy link
Collaborator Author

Forgot to commit the bytecode files

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Contract sizes:

 | Contract                     | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
 |------------------------------|------------------|-------------------|--------------------|---------------------|
-| AccountFactory               | 6,661            | 7,135             | 17,915             | 42,017              |
-| AllowlistModule              | 10,336           | 10,363            | 14,240             | 38,789              |
-| ExecutionInstallDelegate     | 5,947            | 5,993             | 18,629             | 43,159              |
-| ModularAccount               | 23,273           | 23,672            | 1,303              | 25,480              |
-| NativeTokenLimitModule       | 5,093            | 5,120             | 19,483             | 44,032              |
-| PaymasterGuardModule         | 2,097            | 2,124             | 22,479             | 47,028              |
-| SemiModularAccount7702       | 23,741           | 24,133            | 835                | 25,019              |
-| SemiModularAccountBytecode   | 24,223           | 24,622            | 353                | 24,530              |
-| SingleSignerValidationModule | 3,976            | 4,003             | 20,600             | 45,149              |
-| TimeRangeModule              | 2,504            | 2,531             | 22,072             | 46,621              |
-| WebAuthnFactory              | 4,367            | 4,801             | 20,209             | 44,351              |
-| WebAuthnValidationModule     | 9,462            | 9,489             | 15,114             | 39,663              |
+| AccountFactory               | 6,604            | 7,071             | 17,972             | 42,081              |
+| Address                      | 16               | 44                | 24,560             | 49,108              |
+| AllowlistModule              | 10,148           | 10,174            | 14,428             | 38,978              |
+| Base64                       | 16               | 44                | 24,560             | 49,108              |
+| Create2                      | 16               | 44                | 24,560             | 49,108              |
+| ECDSA                        | 16               | 44                | 24,560             | 49,108              |
+| ERC165Checker                | 16               | 44                | 24,560             | 49,108              |
+| ERC1967Utils                 | 16               | 44                | 24,560             | 49,108              |
+| ExecutionInstallDelegate     | 5,835            | 5,880             | 18,741             | 43,272              |
+| FCL_Elliptic_ZZ              | 16               | 44                | 24,560             | 49,108              |
+| FCL_ecdsa                    | 16               | 44                | 24,560             | 49,108              |
+| Math                         | 16               | 44                | 24,560             | 49,108              |
+| MessageHashUtils             | 16               | 44                | 24,560             | 49,108              |
+| ModularAccount               | 22,935           | 23,323            | 1,641              | 25,829              |
+| NativeTokenLimitModule       | 4,917            | 4,943             | 19,659             | 44,209              |
+| PaymasterGuardModule         | 2,028            | 2,054             | 22,548             | 47,098              |
+| SafeERC20                    | 16               | 44                | 24,560             | 49,108              |
+| SemiModularAccount7702       | 23,380           | 23,761            | 1,196              | 25,391              |
+| SemiModularAccountBytecode   | 23,856           | 24,244            | 720                | 24,908              |
+| SignatureChecker             | 16               | 44                | 24,560             | 49,108              |
+| SignedMath                   | 16               | 44                | 24,560             | 49,108              |
+| SingleSignerValidationModule | 3,892            | 3,918             | 20,684             | 45,234              |
+| StorageSlot                  | 16               | 44                | 24,560             | 49,108              |
+| Strings                      | 16               | 44                | 24,560             | 49,108              |
+| TimeRangeModule              | 2,435            | 2,461             | 22,141             | 46,691              |
+| WebAuthn                     | 16               | 44                | 24,560             | 49,108              |
+| WebAuthnFactory              | 4,318            | 4,741             | 20,258             | 44,411              |
+| WebAuthnValidationModule     | 9,319            | 9,345             | 15,257             | 39,807              |

Code coverage:

File % Lines % Statements % Branches % Funcs
src/account/AccountBase.sol 100.00% (12/12) 100.00% (7/7) 100.00% (2/2) 100.00% (4/4)
src/account/AccountStorageInitializable.sol 100.00% (21/21) 100.00% (26/26) 100.00% (5/5) 100.00% (2/2)
src/account/ModularAccount.sol 100.00% (6/6) 100.00% (6/6) 100.00% (0/0) 100.00% (3/3)
src/account/ModularAccountBase.sol 99.09% (328/331) 96.51% (359/372) 77.59% (45/58) 100.00% (36/36)
src/account/ModularAccountView.sol 100.00% (32/32) 100.00% (31/31) 100.00% (3/3) 100.00% (5/5)
src/account/ModuleManagerInternals.sol 94.03% (63/67) 95.06% (77/81) 63.64% (7/11) 100.00% (4/4)
src/account/SemiModularAccount7702.sol 0.00% (0/9) 0.00% (0/6) 0.00% (0/1) 0.00% (0/3)
src/account/SemiModularAccountBase.sol 90.48% (76/84) 91.92% (91/99) 64.71% (11/17) 100.00% (16/16)
src/account/SemiModularAccountBytecode.sol 100.00% (8/8) 100.00% (7/7) 100.00% (1/1) 100.00% (2/2)
src/account/SemiModularAccountStorageOnly.sol 55.56% (5/9) 50.00% (5/10) 100.00% (0/0) 33.33% (1/3)
src/account/TokenReceiver.sol 33.33% (2/6) 33.33% (1/3) 100.00% (0/0) 33.33% (1/3)
src/factory/AccountFactory.sol 75.81% (47/62) 84.62% (55/65) 50.00% (3/6) 56.25% (9/16)
src/factory/WebAuthnFactory.sol 57.14% (20/35) 68.75% (22/32) 50.00% (3/6) 33.33% (3/9)
src/helpers/ExecutionInstallDelegate.sol 89.39% (59/66) 89.47% (68/76) 25.00% (2/8) 100.00% (7/7)
src/libraries/ExecutionLib.sol 99.66% (297/298) 98.89% (268/271) 90.91% (30/33) 100.00% (24/24)
src/libraries/KnownSelectorsLib.sol 100.00% (18/18) 100.00% (34/34) 100.00% (0/0) 100.00% (2/2)
src/libraries/LinkedListSetLib.sol 95.52% (64/67) 95.12% (78/82) 62.50% (5/8) 100.00% (8/8)
src/libraries/MemManagementLib.sol 100.00% (66/66) 100.00% (70/70) 100.00% (0/0) 100.00% (12/12)
src/libraries/ModuleInstallCommonsLib.sol 64.71% (11/17) 61.54% (8/13) 62.50% (5/8) 100.00% (3/3)
src/libraries/ValidationLocatorLib.sol 70.87% (73/103) 72.04% (67/93) 47.83% (11/23) 85.00% (17/20)
src/modules/ModuleBase.sol 76.92% (20/26) 73.08% (19/26) 66.67% (2/3) 100.00% (4/4)
src/modules/permissions/AllowlistModule.sol 80.19% (85/106) 86.21% (100/116) 79.17% (19/24) 50.00% (9/18)
src/modules/permissions/NativeTokenLimitModule.sol 82.76% (48/58) 87.10% (54/62) 92.31% (12/13) 66.67% (8/12)
src/modules/permissions/PaymasterGuardModule.sol 75.00% (15/20) 77.78% (14/18) 33.33% (1/3) 71.43% (5/7)
src/modules/permissions/TimeRangeModule.sol 88.46% (23/26) 84.62% (22/26) 100.00% (5/5) 87.50% (7/8)
src/modules/validation/SingleSignerValidationModule.sol 82.93% (34/41) 82.05% (32/39) 62.50% (5/8) 90.00% (9/10)
src/modules/validation/WebAuthnValidationModule.sol 63.64% (21/33) 66.67% (18/27) 100.00% (3/3) 60.00% (6/10)
Total 89.37% (1454/1627) 90.64% (1539/1698) 72.29% (180/249) 82.47% (207/251)

@dancoombs dancoombs force-pushed the danc/entrypoint-v090 branch 5 times, most recently from 8c22396 to 2cd128a Compare December 18, 2025 22:38
@dancoombs dancoombs marked this pull request as ready for review December 18, 2025 22:39
@dancoombs dancoombs force-pushed the danc/entrypoint-v090 branch from 2cd128a to 00d4415 Compare December 18, 2025 22:41
fix: commit ep v0.9.0 bytecode file
@dancoombs dancoombs force-pushed the danc/entrypoint-v090 branch from 00d4415 to 151ee74 Compare December 18, 2025 22:42
target: address(erc20), value: 0, data: abi.encodeCall(IERC20.approve, (recipient, 9 ether + 100_000))
});

vm.startPrank(address(entryPoint));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - this isn't needed

Comment on lines +30 to +32
// update
assertEq(senderCreator.codehash, 0xa7d4dd260bca9c96da49f7c0682fdda7f0074694d935815a336d3e60ee3ec6ad);
// update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: leftover // update comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in a follow up

@dancoombs dancoombs merged commit 9e235f0 into develop Dec 19, 2025
7 checks passed
@dancoombs dancoombs deleted the danc/entrypoint-v090 branch December 19, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants