Gen command improvements: Support for subresources and for defining namespace and name of generated roles#102
Open
agmimidi wants to merge 3 commits intoalcideio:masterfrom
Conversation
gadinaor
reviewed
Apr 25, 2024
| func generateRole(rules []rbacv1.PolicyRule, namespace string, roleName string) (string, error) { | ||
| var obj runtime.Object | ||
|
|
||
| if generateKind == "ClusterRole" { |
Contributor
There was a problem hiding this comment.
This PR removes support for generating cluster roles - is this intended? I'd rather add have this PR extend the existing behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR provides the following additional functionality.
--useSubresouces.When this is defined, then the gen command also includes Kubernetes subresources (e.g. pods/exec) when generating Roles or Cluster roles. To avoid breaking existing functionality, default behaviour is to have this flag disabled.--roleNameand--namespaceto define the name of the generated (cluster)role and of the target namespace. If none is defines, default behaviour is maintained (name=myRole,namespace=myNamespace)Example use of new flags
Only define namespace and name of Role
rbac-tool gen --roleName me --namespace mine --deny-resources=secrets.,services. --allowed-verbs=get,list --generated-type=RoleInclude also subresources
rbac-tool gen --roleName me --namespace mine --deny-resources=secrets.,services. --allowed-verbs=get,list --generated-type=Role --useSubresourcesTested in an M1 Chip
out_no_subresources.txt
out_subresources_no_names.txt
out_subresources.txt