Skip to content

Conversation

@nicklamiller
Copy link
Contributor

@nicklamiller nicklamiller commented Oct 18, 2025

@ale94mleon Really nice work on this package!

As I was reading through, I noticed the GitHub Actions workflow files were in a github directory, but GitHub Actions expects a .github directory and, if it exists, looks there for workflow files (source):

Workflows are defined in the .github/workflows directory in a repository.

You'll see the GitHub Actions CI is automatically triggered from opening this PR with this change (as specified in the tests.yml and codeql-analysis.yml files):

pull_request:
branches: [ "main" ]

pull_request:
# The branches below must be a subset of the branches above
branches: [ "main" ]

However, since I don't have write access to this repo, I believe you'll have to approve this workflow run for the actual CI checks to run.

@nicklamiller nicklamiller changed the title Rename folder containing GitHub Actions yamls got .github so discoverable Rename folder containing GitHub Actions yamls to .github so discoverable Oct 18, 2025
@ale94mleon
Copy link
Owner

Hi @nicklamiller, you are absolutely right: GitHub needs.github so the CI/CD are trigger. But it is completely intentional as it is right now; as I do not want to trigger the CI/CD at the moment.

The provided default GitHub's runners are very slow to run the BindFlow tests, making the CI/CD completely useless. I would need for that to use local runners. For that I need to configure some of our current local computers so they run the BindFlow's CI/CD. This is still in progress ...

For now you should run the test locally when BindFlow is installed, so you are sure everything is OK.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ale94mleon ale94mleon self-requested a review October 18, 2025 17:27
Copy link
Owner

@ale94mleon ale94mleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this and move test CI from folder

@ale94mleon ale94mleon merged commit 63d4dfd into ale94mleon:main Oct 18, 2025
3 of 9 checks passed
@nicklamiller
Copy link
Contributor Author

@ale94mleon Ah I see, thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants