Add a generic BindFor that can usually replace BindTo#590
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Mar 31, 2026
Merged
Add a generic BindFor that can usually replace BindTo#590alecthomas merged 1 commit intoalecthomas:masterfrom
BindFor that can usually replace BindTo#590alecthomas merged 1 commit intoalecthomas:masterfrom
Conversation
Contributor
Author
|
Open to other namings - e.g. |
alecthomas
reviewed
Mar 31, 2026
options_test.go
Outdated
|
|
||
| var cli struct{} | ||
|
|
||
| p, err := New(&cli, BindFor(iface(impl("foo")))) |
Owner
There was a problem hiding this comment.
I like the concept, but this doesn't seem like a significant ergonomic improvement as it's still quite verbose and a bit unintuitive
Contributor
Author
There was a problem hiding this comment.
It's not so obvious in the test suite so maybe that needs clarification/a better example, but if you use BindFor(ctx) with a context.Context it will do the the right thing, which is the big win IMO.
jwreschnig-utiq
force-pushed
the
bindfor
branch
from
9f159b4 to
20bf6e4
Compare
alecthomas
approved these changes
Mar 31, 2026
When this infers the type of interfaces at compile-time it’s usually more ergonomic.
jwreschnig-utiq
force-pushed
the
bindfor
branch
from
20bf6e4 to
08eb5da
Compare
Owner
|
Thanks! |
Contributor
|
Awesome. This works great for me and my use of With: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.