Skip to content

Performance improvement #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugoferreira wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Performance improvement #448

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8025988
IThis change adds a `sync.Pool` of `contextFieldSet` objects.
hugoferreira Nov 24, 2025
479c9c4
Decrease short-lived context copies
hugoferreira Nov 24, 2025
c211a73
Cleaned-up func `(p *parseContext) Apply() error` to keep existing st…
hugoferreira Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"io"
"reflect"
"strings"
"sync"

"github.com/alecthomas/participle/v2/lexer"
)
Expand All @@ -29,6 +30,10 @@ type parseContext struct {
allowTrailing bool
}

var contextFieldSetPool = sync.Pool{
New: func() any { return &contextFieldSet{} },
}

func newParseContext(lex *lexer.PeekingLexer, lookahead int, caseInsensitive map[lexer.TokenType]bool) parseContext {
return parseContext{
PeekingLexer: *lex,
Expand All @@ -49,18 +54,23 @@ func (p *parseContext) DeepestError(err error) error {

// Defer adds a function to be applied once a branch has been picked.
func (p *parseContext) Defer(tokens []lexer.Token, strct reflect.Value, field structLexerField, fieldValue []reflect.Value) {
p.apply = append(p.apply, &contextFieldSet{tokens, strct, field, fieldValue})
set := contextFieldSetPool.Get().(*contextFieldSet)
*set = contextFieldSet{tokens, strct, field, fieldValue}
p.apply = append(p.apply, set)
}

// Apply deferred functions.
func (p *parseContext) Apply() error {
var err error
for _, apply := range p.apply {
if err := setField(apply.tokens, apply.strct, apply.field, apply.fieldValue); err != nil {
return err
if err == nil {
err = setField(apply.tokens, apply.strct, apply.field, apply.fieldValue)
}
*apply = contextFieldSet{}
contextFieldSetPool.Put(apply)
}
p.apply = nil
return nil
return err
}

// Branch accepts the branch as the correct branch.
Expand Down