Add HideName option to printer#33
Merged
alecthomas merged 1 commit intoalecthomas:masterfrom Jun 5, 2025
Merged
Conversation
alecthomas
requested changes
Jun 5, 2025
repr.go
Outdated
| } | ||
| } | ||
|
|
||
| func HideName(name string) Option { |
Owner
There was a problem hiding this comment.
I don't mind the idea, but can you rename this to HideField or something similar, as "name" is a bit ambiguous - it could be field name or type name.
Owner
There was a problem hiding this comment.
Also can you write a doc comment please?
Contributor
Author
There was a problem hiding this comment.
No problem, ive done this now :)
Owner
There was a problem hiding this comment.
Thanks!
Also, NZ represent! :)
LeonHuston
force-pushed
the
ignore-struct-field-by-name
branch
from
10e4ceb to
66daa83
Compare
alecthomas
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have run into a situation where we are using
assertto compare some structs, however some of these structs have some fields we don't care about but the same type as one of the fields we are directly trying to compare. This means the existingHideoption does not work because it will exclude everything.This PR adds a slightly alternative option
HideNamewhich will hide all struct fields matching that given name, i've kept it at struct names for now but it could be extended to map keys too if we so wished. Included a test similar to the existing ones, but if you want more let me know :)