Add support for RETRY_EXCEPTIONS setting
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alecxe hello. Can you review this one and release a new version to PyPI? |
|
Just in case if somebody else is also looking for this change - since this project seems to be no longer maintained, I've built a new one that will work with modern Scrapy versions. Take a look at scrapy-ua-rotator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41.
I tested locally with Scrapy 2.9.0, 2.10.0 and 2.11.0.
2.10 is the version with exception upon accessing
EXCEPTIONS_TO_RETRY. In 2.11 this error was fixed.On all versions middleware does not fail when
process_exceptionis called. On 2.10+ the middleware also respects settingRETRY_EXCEPTIONS.I am not sure how to add tests with specific scrapy version.