Conversation
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.10. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.3...1.5.10) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This is a straightforward Dependabot security update that bumps url-parse from 1.5.3 to 1.5.10, fixing multiple CVEs (CVE-2022-0691, CVE-2022-0686, and others related to URL parsing vulnerabilities including control character stripping and empty port handling). The diff is almost entirely lock file changes, with url-parse correctly updated in both package-lock.json and yarn.lock. The collateral changes (marking several packages as devDependencies, upgrading @solana/web3.js from 0.90.5 to 1.35.1 with updated transitive deps, jayson uuid from v3 to v8, rpc-websockets patch bump, ws patch bump) appear to be npm's automatic lock file resolution when regenerating the tree. These are all lock file artifacts — the actual package.json is not modified by this PR. The url-parse package is listed as a dev dependency (used only in testing/build tooling), so the security risk of the old version was already limited. No source code changes are included.
package-lock.json (line None): The lock file reflects a significant implicit upgrade of @solana/web3.js from 0.90.5 to 1.35.1, along with its new dependencies (borsh, cross-fetch, @solana/buffer-layout, @ethersproject/sha2, superstruct 0.14.2 vs 0.8.4). This is a major version jump for a transitive dependency and wasn't the stated intent of the PR. It may be harmless if aleph-js doesn't use @solana/web3.js APIs that changed between these major versions, but it warrants awareness. The package.json likely pins a range that accommodates both versions. Worth verifying that Solana-related functionality still works as expected after this upgrade.
Bumps url-parse from 1.5.3 to 1.5.10.
Commits
8cd4c6c1.5.10ce7a01f[fix] Improve handling of empty port0071490[doc] Update JSDoc commenta7044e3[minor] Use more descriptive variable named547792[security] Add credits for CVE-2022-0691ad233571.5.90e3fb54[fix] Strip all control characters from the beginning of the URL61864a8[security] Add credits for CVE-2022-0686bb0104d1.5.8d5c6479[fix] Handle the case where the port is specified but emptyDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.