Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
+ Coverage 68.59% 68.62% +0.03%
==========================================
Files 104 104
Lines 11812 11821 +9
Branches 1007 1010 +3
==========================================
+ Hits 8102 8112 +10
+ Misses 3448 3446 -2
- Partials 262 263 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d76df62 to
c515807
Compare
6713f9b to
23087df
Compare
| if getattr(volume, "size_mib", None): | ||
| disk_size_mib += volume.size_mib | ||
|
|
||
| return disk_size_mib |
There was a problem hiding this comment.
Why do we need this if it's coming from the message itself? I don't like that the node can report whatever it wants.
There was a problem hiding this comment.
Because on the message we don't have the real sizes used on the VMs, like on volumes and on runtime and code. The idea of this PR is to show the real resources used by the VMs. Indeed the PR need tobe finished solving the TODO tasks, I have put on review just to check the format.
There was a problem hiding this comment.
From our conversation earlier, the goal of this PR is unclear. Let's not merge it until its purpose is clarified.
23087df to
bff740b
Compare
Add a new
resourcesfield on existing endpoint/v2/about/executions/resourcesto expose resources for instancesRelated ClickUp, GitHub or Jira tickets : ALEPH-615
Opening this PR so we can discuss what info we need and the format.
Examples of what this endpoint will return, this is basically the same endpoint with added
resourcefield.