pool: stop and remove orphan controller services on supervisor startup#933
Merged
pool: stop and remove orphan controller services on supervisor startup#933
Conversation
Forgotten VMs left behind stale controller.json files and sometimes running aleph-vm-controller@<hash>.service units with active qemu processes that kept consuming host RAM. The admission check iterates pool.executions and did not see these orphans, so the host's real free memory was lower than the check computed. On load_persistent_executions, scan EXECUTION_ROOT for controller configs whose vm_hash is not in the pool, stop_and_disable the matching systemd service, and delete the config file.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
- Coverage 68.48% 68.35% -0.13%
==========================================
Files 104 104
Lines 11955 11983 +28
Branches 1020 1023 +3
==========================================
+ Hits 8187 8191 +4
- Misses 3503 3527 +24
Partials 265 265 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgotten VMs left behind stale controller.json files and sometimes
running aleph-vm-controller@.service units with active qemu
processes that kept consuming host RAM. The admission check iterates
pool.executions and did not see these orphans, so the host's real
free memory was lower than the check computed.
On load_persistent_executions, scan EXECUTION_ROOT for controller
configs whose vm_hash is not in the pool, stop_and_disable the
matching systemd service, and delete the config file.