Annotation load from config and display#18
Open
JulieWinchester wants to merge 13 commits intomainfrom
Open
Conversation
…of same file in scene
…d annotations black
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the viewer's annotation capabilities and refines the UI for model selection and scene interaction.
- Enables loading annotations from a source configuration and displays them using a new annotation toolbar.
- Introduces a control toolbar for toggling scene components, updates various UI components, and revises state management in the store.
- Reorganizes files by adding new components (e.g., Toolbar, Dropdown, SourceSelector) and removing obsolete ones.
Reviewed Changes
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/components/ui/tooltip.tsx | Adds an optional "side" prop to configure tooltip placement. |
| src/components/ui/toolbar.tsx | Introduces reusable toolbar components for UI controls. |
| src/components/ui/dropdown.tsx | Creates a new dropdown component for annotation selection. |
| src/components/ui/button.tsx | Adds a new "iconSm" variant to the button component. |
| src/components/tab.tsx | Simplifies tab layout by removing an unused DisplayControls import. |
| src/components/source-selector.tsx | Implements source selection with redundant state update call. |
| src/components/scene-tab.tsx | Updates scene tab to incorporate new source and camera selectors. |
| src/components/rotation-controls-selector.tsx | Adds a boolean selector for rotation controls. |
| src/components/gltf.tsx | Switches from primitive to Clone for glTF model rendering. |
| src/components/control-toolbar.tsx | Provides a new control toolbar for scene reset and toggling views. |
| src/components/annotation-tools.tsx | Updates annotation tool behaviors based on a view-only mode. |
| src/components/annotation-toolbar.tsx | Creates annotation navigation toolbar with dropdown selection. |
| src/components/annotation-tab.tsx | Adjusts layout and text capitalization in the annotation tab. |
| src/Store.ts | Renames and adds state properties for rotation controls and source collections. |
| src/App.tsx | Revises config usage for single and multiple sources, and updates effect hooks. |
Files not reviewed (1)
- package.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR builds on #17 and that PR should be reviewed/decided on first.
This PR: