[ENG-59904 & ENG-59904: Cisco AMP and Cisco Duo collector] : Migrate the code from callback to async/await#410
Open
rakhimundhada15 wants to merge 2 commits intoalertlogic:masterfrom
Open
Conversation
CI Service Job Number 1153 Logs - SUCCESS
Stages Run:
|
a937e20 to
357fc2c
Compare
CI Service Job Number 1154 Logs - SUCCESS
Stages Run:
|
CI Service Job Number 1155 Logs - SUCCESS
Stages Run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Currently, our collector is using Node.js 22 with AWS SDK v3, which support both callback and async/await both. However, it appears that support for callback will be deprecated in Node.js 24 or later versions
Solution Description