Skip to content

[ENG-59904 & ENG-59904: Cisco AMP and Cisco Duo collector] : Migrate the code from callback to async/await#410

Open
rakhimundhada15 wants to merge 2 commits intoalertlogic:masterfrom
rakhimundhada15:ENG-59904
Open

[ENG-59904 & ENG-59904: Cisco AMP and Cisco Duo collector] : Migrate the code from callback to async/await#410
rakhimundhada15 wants to merge 2 commits intoalertlogic:masterfrom
rakhimundhada15:ENG-59904

Conversation

@rakhimundhada15
Copy link
Contributor

Problem Description
Currently, our collector is using Node.js 22 with AWS SDK v3, which support both callback and async/await both. However, it appears that support for callback will be deprecated in Node.js 24 or later versions

Solution Description

  1. Refactor the code to use async/promise AWS functions and update the test cases.
  2. updated the the al-aws-collector and paws-collector lib version to sync latest async/promise changes .# pr 404 ,#409

@al-cibot
Copy link

al-cibot commented Mar 6, 2026

CI Service Job Number 1153 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1153 -g

Stages Run:

  • PR Test

@al-cibot
Copy link

al-cibot commented Mar 6, 2026

CI Service Job Number 1154 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1154 -g

Stages Run:

  • PR Test

@rakhimundhada15 rakhimundhada15 changed the title [ENG-59904: Cisco AMP collector] : Migrate the code from callback to async/await [ENG-59904 & ENG-59904: Cisco AMP and Cisco Duo collector] : Migrate the code from callback to async/await Mar 6, 2026
@al-cibot
Copy link

al-cibot commented Mar 6, 2026

CI Service Job Number 1155 Logs - SUCCESS

alps ci job-logs --organization alertlogic --repository paws-collector --job-num 1155 -g

Stages Run:

  • PR Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants