Escape HTTP MCP server URLs in Windows CMD execution #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completes the URL escaping fix for Windows by handling the remaining direct execution paths that were missed in commit 4f475ca. Previous fix addressed PowerShell scripts and Unix bash commands but missed two critical Windows CMD execution paths. Changes: - Add escape_for_cmd() function to escape CMD special characters (^, &, |, <, >, %) - Fix direct execution fallback path to use escaped URLs on Windows - Fix retry path to use escaped URLs on Windows - Add 7 comprehensive tests for URL escaping functionality The ^ character is escaped first to prevent double-escaping of subsequently escaped characters. Resolves Windows CMD interpretation of & as command separator in HTTP MCP URLs.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the URL escaping fix for Windows by handling the remaining direct execution paths that were missed in commit 4f475ca. Previous fix addressed PowerShell scripts and Unix bash commands but missed two critical Windows CMD execution paths.
Changes:
The ^ character is escaped first to prevent double-escaping of subsequently escaped characters.
Resolves Windows CMD interpretation of & as command separator in HTTP MCP URLs.