Use shell=True for Windows CMD URL escaping #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace caret (^) escaping approach with shell=True and double-quoted URLs for Windows CMD compatibility. The previous escape_for_cmd() approach failed because subprocess.run() with list arguments uses subprocess.list2cmdline() which follows MSVC quoting rules, not CMD escaping rules. When calling .CMD batch files, Windows automatically invokes cmd.exe /c, causing & characters to be interpreted as command separators despite caret escaping. Using shell=True with double-quoted URLs ensures & characters are protected from CMD interpretation, as documented in Python's subprocess documentation for batch files with special characters.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace caret (^) escaping approach with shell=True and double-quoted URLs for Windows CMD compatibility.
The previous escape_for_cmd() approach failed because subprocess.run() with list arguments uses subprocess.list2cmdline() which follows MSVC quoting rules, not CMD escaping rules. When calling .CMD batch files, Windows automatically invokes cmd.exe /c, causing & characters to be interpreted as command separators despite caret escaping.
Using shell=True with double-quoted URLs ensures & characters are protected from CMD interpretation, as documented in Python's subprocess documentation for batch files with special characters.