Use bash for CLI command execution on all platforms #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from PowerShell/CMD to bash (Git Bash on Windows, native bash on Unix) for all CLI command execution. This provides consistent cross-platform behavior and eliminates Windows-specific issues. Key changes: - Add find_bash_windows() to locate Git Bash executable - Add run_bash_command() helper for cross-platform bash execution - Replace PowerShell execution with bash in execute_dependency() - Replace PowerShell/CMD with bash in configure_mcp_server() for HTTP transport - Unify Windows and Unix code paths to use run_bash_command() Benefits: - Consistent cross-platform CLI execution via bash - Fixes URL escaping issues with & characters in MCP server URLs - Eliminates PowerShell false-positive non-zero exit codes - Simpler and more maintainable codebase with unified execution logic
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from PowerShell/CMD to bash (Git Bash on Windows, native bash on Unix) for all CLI command execution. This provides consistent cross-platform behavior and eliminates Windows-specific issues.
Key changes:
Benefits: