Resolve MCP server configuration retry missing PATH export #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix critical bug where retry logic in configure_mcp_server() was missing the PATH export that was present in the first attempt, causing retry failures when Node.js was not in system PATH. Changes: - Fix retry to include explicit PATH export with Node.js location (critical bug fix) - Add debug logging infrastructure controlled by CLAUDE_CODE_TOOLBOX_DEBUG environment variable - Add is_debug_enabled() and debug_log() helper functions for diagnostic output - Enhance find_bash_windows() with debug logging for path resolution - Enhance run_bash_command() with command execution details - Enhance configure_mcp_server() with MCP configuration details - Add comprehensive tests for debug functions The debug logging helps diagnose MCP server configuration issues and can be enabled by setting CLAUDE_CODE_TOOLBOX_DEBUG=1
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix critical bug where retry logic in configure_mcp_server() was missing the PATH export that was present in the first attempt, causing retry failures when Node.js was not in system PATH.
Changes:
The debug logging helps diagnose MCP server configuration issues and can be enabled by setting CLAUDE_CODE_TOOLBOX_DEBUG=1