Add automatic npm Claude removal after native installation #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically remove npm-installed Claude Code after successful native installation to prevent PATH conflicts. This ensures only one Claude installation exists when users migrate from npm to native. Implementation: - Add remove_npm_claude() function with safe error handling - Integrate at all 8 native installation success points - Only remove npm version after verified native installation (source == 'native') - Non-blocking design - npm removal failure does not fail native installation Testing: - Add TestRemoveNpmClaude class with 5 unit tests - Fix 3 existing tests affected by the change with @patch decorator
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically remove npm-installed Claude Code after successful native installation to prevent PATH conflicts. This ensures only one Claude installation exists when users migrate from npm to native.
Implementation: