Remove deprecated CLI config update from update_install_method_config #274
+27
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_config Remove dead code from update_install_method_config() that attempted to use the claude config CLI command, which was deprecated in v1.0.7 and removed in v2.0.0. The function now uses only direct file modification to update ~/.claude.json. Changes: - Removed CLI-first strategy and fallback logic - Updated documentation to reflect direct file modification approach - Simplified test suite by removing CLI-related test cases - Preserved all file modification tests and error handling tests
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dead code from update_install_method_config() that attempted to use the claude config CLI command, which was deprecated in v1.0.7 and removed in v2.0.0. The function now uses only direct file modification to update ~/.claude.json.
Changes: