Add MCP server profile scope isolation #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements scope: profile for MCP servers, enabling true isolation where servers are visible only when using a specific profile command.
Profile-scoped servers are stored in {command}-mcp.json and loaded via --strict-mcp-config --mcp-config flags, preventing cross-contamination between different environment profiles.
Key changes:
- Add create_mcp_config_file() to generate profile MCP config JSON
- Modify configure_all_mcp_servers() to separate profile from regular servers
- Update launcher scripts to detect and use --strict-mcp-config when profile servers exist
- Add 15+ tests covering all profile scope scenarios
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements scope: profile for MCP servers, enabling true isolation where servers are visible only when using a specific profile command.
Profile-scoped servers are stored in {command}-mcp.json and loaded via --strict-mcp-config --mcp-config flags, preventing cross-contamination between different environment profiles.
Key changes: