Add combined scope support for MCP servers and fix parsing MCP profile config commands #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable MCP servers to be configured with combined scopes (e.g., scope: [user, profile]) allowing servers to be available both in profile isolation and globally. - Add validate_scope_combination() to validate scope combinations - Add normalize_scope() to normalize scope values (string/list/comma-separated) - Modify configure_all_mcp_servers() to handle multiple scopes per server - Add 47 comprehensive tests in TestCombinedScopeSupport class - Support backward compatibility with existing single-scope configurations
Fixes two bugs in MCP profile server configuration: - Tilde paths (~/.claude/...) not expanded to absolute paths - Commands stored as raw strings instead of command+args structure Added parse_mcp_command() function that: - Expands tilde paths using existing expand_tildes_in_command() - Converts backslashes to forward slashes before shlex parsing - Splits commands into executable and args using shlex - Wraps npx/npm with cmd /c on Windows for proper execution Updated create_mcp_config_file() to use structured format with separate command, args, and env fields per MCP JSON schema.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.