Ensure profile-only MCP servers trigger removal from all scopes #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profile-only servers (scope: profile) were not calling configure_mcp_server(), causing them to skip the removal logic that cleans up servers from user/local/project scopes before applying profile configuration. This fix adds a call to configure_mcp_server() for profile-only servers, which triggers removal from all scopes while skipping the claude mcp add command (via early-return for scope == 'profile'). Added 5 comprehensive test methods to verify the fix and prevent regressions: - Profile-only servers trigger removal from all 3 scopes - Multi-scope servers work correctly with both removal and add - User-scope servers unchanged (regression test) - Multiple profile-only servers handled correctly - Comprehensive scope mix integration test
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profile-only servers (scope: profile) were not calling configure_mcp_server(), causing them to skip the removal logic that cleans up servers from user/local/project scopes before applying profile configuration.
This fix adds a call to configure_mcp_server() for profile-only servers, which triggers removal from all scopes while skipping the claude mcp add command (via early-return for scope == 'profile').
Added 5 comprehensive test methods to verify the fix and prevent regressions: