Skip to content

Conversation

@hb0nes
Copy link
Contributor

@hb0nes hb0nes commented Oct 4, 2024

I made a PR for puppetlabs-firewall to add support for these flags.
Figured I'd add them here as well.

@alex-harvey-z3q alex-harvey-z3q merged commit 97559fd into alex-harvey-z3q:master Oct 6, 2024
alex-harvey-z3q added a commit that referenced this pull request Oct 6, 2024
alex-harvey-z3q added a commit that referenced this pull request Oct 6, 2024
@alex-harvey-z3q
Copy link
Owner

alex-harvey-z3q commented Oct 6, 2024

@hb0nes I have merged too soon! I see your PR here has not been merged yet
puppetlabs/puppetlabs-firewall#1234

In order to raise the same feature here, you would need to firstly have your feature in firewall both merged and released. Once that's done, note that the project here has a script gen_params.sh that code generates based on the checked out firewall module. Do also have a look at that if you want to contribute here. Thanks!

@hb0nes
Copy link
Contributor Author

hb0nes commented Oct 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants