Skip to content

upgrade nethack to 1.0#321

Merged
alex-petrenko merged 2 commits intoalex-petrenko:masterfrom
BartekCupial:gymnasium_nle
May 27, 2025
Merged

upgrade nethack to 1.0#321
alex-petrenko merged 2 commits intoalex-petrenko:masterfrom
BartekCupial:gymnasium_nle

Conversation

@BartekCupial
Copy link
Collaborator

Overview

This PR upgrades nethack to 1.0. Installation is now done with simple pypi command.

pip install sample-factory[nethack]

Changes:

  • nethack upgraded to 1.0, now nethack uses gymnasium instead of gym
  • render utils together with screen rendering observation wrapper were removed, in its place much simpler tileTTY wrapper was added
  • few bug fixes for task metrics

Experiments

I will run some experiments showing that model performance is preserved.

Copy link
Owner

@alex-petrenko alex-petrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR 👍

@alex-petrenko alex-petrenko merged commit 1355efa into alex-petrenko:master May 27, 2025
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants