Skip to content

missing assertions on unit tests #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

missing assertions on unit tests #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions ask-sdk-local-debug/src/com/amazon/ask/localdebug/util/RequestResponseUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,23 @@ public void close() throws IOException {
}, skillResponseByteArray);
break;
case SKILL_STREAM_HANDLER_TYPE:
ReflectionUtils.callMethodAndGetResult(skillInvokerConfiguration.getSkillInvokerMethod(),
skillInvokerConfiguration.getSkillInvokerInstance(),
new ByteArrayInputStream(
localDebugRequest.getRequestPayload()
.getBytes(StandardCharsets.UTF_8)) {
@Override
public void close() throws IOException {
super.close();
}
}, skillResponseByteArray, new DebugLambdaContext());
// Dummy code change to show method invocation is not asserted in JUnit
/*
* ReflectionUtils.callMethodAndGetResult(skillInvokerConfiguration.
* getSkillInvokerMethod(), skillInvokerConfiguration.getSkillInvokerInstance(),
* new ByteArrayInputStream( localDebugRequest.getRequestPayload()
* .getBytes(StandardCharsets.UTF_8)) {
*
* @Override public void close() throws IOException { super.close(); } },
* skillResponseByteArray, new DebugLambdaContext());
*/
break;
default:
// Dummy code change to show default case not checked
final String errorMessage = String.format("Unknown skill configuration type - %s",
skillInvokerConfiguration.getType());
LOG.error(errorMessage);
throw new LocalDebugSdkException(errorMessage);
return "dummy response";
}
final String skillResponse = skillResponseByteArray.toString(StandardCharsets.UTF_8.toString());
SuccessResponse successResponse = getLocalDebugSuccessResponse(localDebugRequest, skillResponse);
Expand Down