Skip to content

Introduction of support to TTML#15

Draft
alexandercerutti wants to merge 740 commits intodevelopfrom
feature/ttml-adapter
Draft

Introduction of support to TTML#15
alexandercerutti wants to merge 740 commits intodevelopfrom
feature/ttml-adapter

Conversation

@alexandercerutti
Copy link
Owner

@alexandercerutti alexandercerutti commented Feb 18, 2024 •
edited
Loading

Breaking changes

  • (Re)Introduced Entities.Style;
  • Removed Entities.Tag.setStyles;
  • Removed the concepts of offset and length in lines;
  • (Behavior) Adapters now are in charge of specifing the entities to apply to specific cues, in a ordered way (captions-renderer won't re-order them anymore)

Todo list

  • Add meaningful error classes instead of generic throw new Error()

@vercel
Copy link

vercel bot commented Feb 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sub37-sample Ready Ready Preview, Comment Mar 18, 2026 11:36pm

@alexandercerutti alexandercerutti linked an issue Feb 18, 2024 that may be closed by this pull request
Multi line does not preserve style #11
Closed
@alexandercerutti alexandercerutti changed the title Introduction of support to TTML Adapter Introduction of support to TTML Feb 18, 2024
@alexandercerutti alexandercerutti self-assigned this Feb 24, 2024
@alexandercerutti
Reworked active region styles extraction to share the logic
20bfc67
@alexandercerutti
Improved whole temporal active context store and style processing to …
b8d1351 
…make it clearer
@alexandercerutti
Set Temporal Active Context store to be different and contain direct …
5004e65 
…references
@alexandercerutti
Added extraction of animation references in TemporalActiveContext
8121861
@alexandercerutti
Added animations getter
44071fd
@alexandercerutti
Removed unused getter styleIDRefs
3acb35f
@alexandercerutti
Removed getter regionIdRef for region getter instead
c56f053
@alexandercerutti
Uniformed onMergeSymbol parameter name
745b48b
@alexandercerutti
Merged conditions
06b3c81
@alexandercerutti
Improved comments and function naming
08b4c45
@alexandercerutti
Improved comment positions on how ISD processing happens and how the …
3ad6ecc 
…linear processing works
@alexandercerutti
Added support to animation when computing the cue time segments to un…
91dca2c 
…derstand how many cues should be created
@alexandercerutti
Added core animation entity to be remapped in the caption-renderer
c91d7bf
@alexandercerutti
Fixed validateAnimation signature as items may be undefined
360198f
@alexandercerutti
Added comment
32b908b
@alexandercerutti
Improved keysplines calculation code and signatures
327cf33
@alexandercerutti
Added explanation for controlsList and splines
0bd64ba
@alexandercerutti
Reworked how anymations are created, with a BaseAnimation and distinc…
34330ee 
…t types for each calcMode
@alexandercerutti
Added new type Spline
d40a5e2
@alexandercerutti
Moved styleFrames computation and discard outside of single animation…
6a58cb6 
… functions
@alexandercerutti
Improved the AnimationEntity
0e126f2
@alexandercerutti
Switched how animation is assigned in order to not have it undefined
2e5c25d
@alexandercerutti
Refactored keyTimes utils
784df63
@alexandercerutti
Converted spline animation to have a keySplines getter for late compu…
cec70e7 
…tation
@alexandercerutti
Fixed wrong string
d5e19bb
@alexandercerutti
Fixed lack of support to region animate attribute
64dee7f
@alexandercerutti
Improved isInlineAnimation in order to check differently if an elemen…
1f803e6 
…t supports animate attribute. This plays on the fact that any element that supports animate attribute actually supports Animation.class*
@alexandercerutti
Fixed type for animation fill
293a4f3
@alexandercerutti
Added Animation Styles CSS conversion
576b38b
@alexandercerutti
Added animation temporal segments generation and association with cues
5b07507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@alexandercerutti alexandercerutti

Labels

💥 Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multi line does not preserve style

1 participant

@alexandercerutti