Use otp_des_key instead of roundcube's des_key#136
Open
aerth wants to merge 3 commits intoalexandregz:masterfrom
Open
Use otp_des_key instead of roundcube's des_key#136aerth wants to merge 3 commits intoalexandregz:masterfrom
aerth wants to merge 3 commits intoalexandregz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know what I'm doing. This probably needs some sort of additional changes.
I think it would be a good idea to use a separate key than roundcube's login key.
So this adds that to twofactor_gauthenticator.
Again, I don't know what I'm doing in php. 🤣
This hopefully also changes the default config fields where all users can optionally enable 2fa themselves. This PR keeps the old config fields as examples (commented)
This way, its ready to use after generating a new key.
I use a reverse proxy so the previous whitelist didn't make sense so I guess it works as
null, which makes sense as a sane default.