Skip to content

support retrieving all property values via ramda #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexkolson wants to merge 5 commits into
base: master
Choose a base branch
from
Open

support retrieving all property values via ramda #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b07dcf8
fixes #2
alexkolson Oct 3, 2019
c67f238
address feedback
alexkolson Oct 30, 2019
8accdb7
get all props function
alexkolson Oct 30, 2019
8c62d42
add test for all props
alexkolson Oct 30, 2019
724d0dd
fix linting erros
alexkolson Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/create-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ export const canonize = r.pipe(
)

const explodeOnUnknownProp = (obj, prop) => {
if (prop === '@@functional/placeholder') {
return
}

if (prop in obj) {
return obj[prop]
}
Expand Down Expand Up @@ -86,5 +90,13 @@ export const createType = propDefs => {
over: r.map(r.over)(lenses)
})

return r.merge(fnsPerProp, { pickAll: r.pick(r.values(nameMap)) })
const pickAll = r.pick(r.values(nameMap))

return r.merge(fnsPerProp, {
pickAll,
allProps: r.pipe(
pickAll,
r.values
)
})
}
14 changes: 13 additions & 1 deletion src/create-type.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,23 @@ describe('KISS type', () => {
})
it('fails on attempted access to unknown props', () => {
const failsNicely = __.throws(
__.typedError(TypeError, __.containsString('unknown'))
__.typedError(TypeError, __.containsString('Unknown'))
)
__.assertThat(() => type.get.unknown, failsNicely)
__.assertThat(() => type.set.unknown, failsNicely)
})
it('all props can be retrieved with ramda', () => {
const doesNotThrow = __.not(__.throws())

const getAllProps = r.pipe(
r.prop('props'),
r.values
)
__.assertThat(() => getAllProps(type), doesNotThrow)
})
it('all props can be retrieved via allProps', () => {
__.assertThat(type.allProps({ prop: 42 }), __.is([42]))
})
})

describe('with getter enhancer', () => {
Expand Down