You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks! I'll be honest in that I don't really know what these parameters are. Can you explain a bit more your rationale for sending this PR? The PR description is blank and the commit carries no information other than what the PR title already has, and I'm not really equipped to reverse-engineer what's going on here.
Also, are you sure this is safe from a safe Rust point of view? Some of the descriptions of these variables and usages internally looks like the constructor probably wants to be unsafe because it seems like things could behave badly if this is misconfigured.
And finally, in C if these are #defines do you know how it affects runtime performance if these are runtime-defined values? If that's a problem should they be associated constants perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.