libssh2-sys: use src instead .git as vendored indicator#241
Open
catap wants to merge 1 commit intoalexcrichton:masterfrom
Open
libssh2-sys: use src instead .git as vendored indicator#241catap wants to merge 1 commit intoalexcrichton:masterfrom
libssh2-sys: use src instead .git as vendored indicator#241catap wants to merge 1 commit intoalexcrichton:masterfrom
Conversation
When someone vendored `libssh-sys` he may exclude `.git` folder. When such things happened an attempt to build it may lead to error like: `fatal: not a git repository (or any of the parent directories): .git`.
Contributor
|
This will resolve #288 once committed. |
Collaborator
|
The error may be printed, but it should not stop compilation unless the vendored copy of |
|
Hi, @yodaldevoid . I would like this PR to be merged too. I build Rust using a different build system than cargo, which tracks and logs all file accesses made during the build to determine if a build needs to be rerun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone vendored
libssh-syshe may exclude.gitfolder.When such things happened an attempt to build it may lead to error like:
fatal: not a git repository (or any of the parent directories): .git.