Skip to content

Fixed Binary Dependency, Removed #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fantypants wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed Binary Dependency, Removed #30

fantypants wants to merge 2 commits into from

Conversation

@fantypants
Copy link
Collaborator

@fantypants fantypants commented Jan 29, 2019

Removes the dependency Binary and replaces with :binary

@fantypants
Copy link
Collaborator Author

fantypants commented Jan 29, 2019

Tests for the load16 etc are failing, i think that's what you fixed earlier? I left the test file aside from changing some Binary to :binary in 2 functions =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexdovzhanyn alexdovzhanyn Awaiting requested review from alexdovzhanyn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fantypants