Support for configurable time formats - #101
Open
alexejk wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alexejk
force-pushed
the
time-formats
branch
2 times, most recently
from
August 31, 2026 15:16
7063a9e to
4cf51fa
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #100.
<dateTime.iso8601>was hardcoded totime.RFC3339in both directions, which doesn't match what servers actually emit — the spec shows a compact example, mandates no layout, and leaves timezone assumptions to server documentation.A new
TimeFormatoption makes encoding and decoding configurable:Fields come in two pairs:
Format*controls what goes on the wire,Parse*what is accepted off it. Servers doing something stranger can implement theTimeFormatterinterface directly.Defaults are unchanged. With no option set, values encode and decode exactly as before, including time.Parse's handling of offsets that match the local
zone. The one observable difference is that a failed default parse now returns a wrapped error rather than a bare *time.ParseError — errors.As still works, a direct type assertion does not.
Thanks to @stricker-devmode for raising this and for the analysis in #100.
Stack created with GitHub Stacks CLI • Give Feedback 💬