Skip to content

Pin k8sgpt to v0.4.36 - #1282

Merged
alexellis merged 1 commit into
masterfrom
pin-k8sgpt
Sep 4, 2026
Merged

Pin k8sgpt to v0.4.36#1282
alexellis merged 1 commit into
masterfrom
pin-k8sgpt

Conversation

@alexellis

Copy link
Copy Markdown
Owner

Pins k8sgpt to v0.4.36, transient: v0.4.38 (latest) shipped no binaries - only an SBOM file - so generated URLs 404.

Upstream issue: k8sgpt-ai/k8sgpt#1775

Verified v0.4.36 assets return 200 and go run . get k8sgpt --os linux --arch x86_64 --verify passes.

Linked issue filed upstream: k8sgpt-ai/k8sgpt#1775

v0.4.38 (latest) shipped no binaries, only an SBOM file, so the
generated download URLs 404. Pin to v0.4.36 where binaries exist,
transient until upstream re-attaches the binaries.

Issue: k8sgpt-ai/k8sgpt#1775
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@reviewfn

reviewfn Bot commented Sep 4, 2026

Copy link
Copy Markdown

AI Pull Request Overview

Disclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification.

Summary

  • Pins k8sgpt default downloads to v0.4.36 to avoid the broken latest release asset set.
  • Adds an inline transient-pin justification with upstream issue context and unpin guidance.
  • Leaves the existing k8sgpt URL template unchanged.
  • Existing k8sgpt URL-generation tests already cover v0.4.36 for Linux, Darwin, and Windows architectures.
  • No blocking correctness, regression, or security issues were found in the scoped diff.

Approval rating (1-10)

9/10. The change is narrow, justified, and consistent with the repository’s existing transient pin pattern.

Summary per file

Summary per file
File path Summary
pkg/get/tools.go Pins k8sgpt to v0.4.36 with transient upstream-release justification.

Overall Assessment

The scoped change is appropriate for the stated failure mode: default version resolution would otherwise select a latest release whose assets are unsuitable for the existing download template. The explicit Version field only affects default resolution; callers that pass a specific version still override it. The comment provides enough context for future maintainers to revisit and remove the pin when upstream restores binaries.

Detailed Review

Detailed Review

No findings.

The k8sgpt tool definition now follows the repository’s documented pattern for transient upstream release problems: it pins the last known working version, explains why the pin exists, references the upstream issue, and states when to unpin. The existing Test_DownloadK8sgpt cases already use v0.4.36 and cover the URL template across the supported OS/architecture combinations, so the final default URL behavior remains aligned with the tested release naming.

AI agent details.

Agent processing time: 1m4.42s
Environment preparation time: 3.693s
Total time from webhook: 1m11.913s

@alexellis
alexellis merged commit 0a0a800 into master Sep 4, 2026
3 of 5 checks passed
@alexellis
alexellis deleted the pin-k8sgpt branch September 4, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant